busybox current status

Roberto A. Foglietta roberto.foglietta at gmail.com
Sat Dec 2 21:53:24 UTC 2006


2006/12/2, Roberto A. Foglietta <roberto.foglietta at gmail.com>:
> 2006/12/1, Denis Vlasenko <vda.linux at googlemail.com>:
> > On Thursday 30 November 2006 13:20, Roberto A. Foglietta wrote:
> >
> > > > To do:
> > > >
> > > > * more fishing in bug database
> > >
> > > the bug n.615 still open and I have updated patch to 1.2.2.1 and today
> > > snapshot (in attachment)
> > > http://bugs.busybox.net/view.php?id=615
> >
> > -               if (temp) {
> > -                       *no_newline = !(len && temp[len-1] == '\n');
> > +               if (temp && len > 0) {
> > +                       endzero += !temp[len-1];
> > +                       *no_newline = !(temp[len-1]=='\n');
> >                         if (!*no_newline) temp[len-1] = 0;
> >                         break;
> >
> > old code: if len == 0: 'break' is taken
> > new code: if len == 0: 'break' is not taken
> > is it ok?
> >
>
> I tested your patch but it seems it does not work at least against
> with 2006-12-01
>
[roberto at nbraf busybox]$ tar xvjf busybox-20061201.tar.bz2
[roberto at nbraf busybox]$ cd busybox
[roberto at nbraf busybox]$ patch -p1 < ../../sed_rev16754.patch
[roberto at nbraf busybox]$ echo -n thingy >z1
[roberto at nbraf busybox]$ echo -n again >z2
[roberto at nbraf busybox]$ ./busybox sed "s/i/z/" z1 z2 | hexdump -vC
00000000 74 68 7a 6e 67 79 61 67 61 7a 6e |thzngyagazn|
0000000b
[roberto at nbraf busybox]$ sed "s/i/z/" z1 z2 | hexdump -vC
00000000 74 68 7a 6e 67 79 0a 61 67 61 7a 6e |thzngy.agazn|
0000000c

 Cheers,
-- 
/roberto



More information about the busybox mailing list