[PATCH] Make start-stop-daemon handle sending signals better

Rich Felker dalias at aerifal.cx
Wed Aug 30 23:50:24 UTC 2006


On Wed, Aug 30, 2006 at 06:53:14PM -0400, Rob Landley wrote:
> It sounds like the problem is we're being too clever.  ls -l /proc/self/exe 
> says that "/proc/self/exe" is a symlink to "/bin/ls", and we really don't 
> care if /bin/ls is a symlink to a shared executable.  The check for device 
> and inode is what's screwing us up, because the heuristic is wrong and we 
> should not do that.  If the same executable is called by two names, it may be 
> performing two functions.  We are.  Call readlink once, use the result in a 
> string comparison, and stop trying to be too clever for our own good.
> 
> Does this sound reasonable?  I'll happily apply a patch to simplify the code 
> and be _less_ clever, if it fixes the problem.

I agree with your assessment of the situation. I too hate it when
programs try to be too smart.

Rich




More information about the busybox mailing list