[PATCH] misc size-shrinkage; merges

Rob Landley rob at landley.net
Tue Aug 29 19:44:43 UTC 2006


On Monday 28 August 2006 7:57 pm, Bernhard Fischer wrote:
> On Sun, Aug 20, 2006 at 04:48:06PM -0400, Rob Landley wrote:
> >On Sunday 20 August 2006 8:31 am, Bernhard Fischer wrote:
> >> On Fri, Aug 18, 2006 at 11:49:01PM -0400, Rob Landley wrote:
> >> >On Friday 18 August 2006 11:53 am, Bernhard Fischer wrote:
> >> >> Hello,
> >> >> 
> >> >> Just a heads up..
> >> >> I plan to push the below patchset (split-up, of course) into my
> >> >
> >> >Yes please.  (Reviewing 4000 lines at once ain't fun.)
> >> >
> >> >> 'busybox_scratch' branch soonish, then merge that branch back into
> >> >> trunk.
> 
> I merged most of the lingering changes off the busybox_scratch branch
> back into trunk in r16009.
> 
> A few notes.
> 
> I mean to merge (parts of) trunk back into my branch.
> There are, however, severe defects on current trunk;
> 
> 1) trunk is b0rk
> This config (off IRC, tell me if it went offline when you happen to read
> this) fails basic tests. http://rafb.net/paste/results/XtWePX12.html
> Failing use-case: echo `echo a=b | cut -d'=' -f2`

Ok, I cleaned up enough of the damage you did (removed the failing inlines, 
except in the e2fsprogs directory which isn't a trivial fix) that I could 
build again, and tried to reproduce your problem:

$ echo `echo a=b | cut -d'=' -f2`
b
$ echo `echo a=b | ./busybox cut -d'=' -f2`
b
$ echo `./busybox echo a=b | ./busybox cut -d'=' -f2`
b
$ ./busybox echo `./busybox echo a=b | ./busybox cut -d'=' -f2`
b

Where exactly is the problem?  Your cut and paste is still 404, and this is 
working for me just fine.

P.S. You are aware that we've had -werror in the tree for months now, right?  
And that it's there for a reason?

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list