svn commit: trunk/busybox/sysklogd

Bernhard Fischer rep.nop at aon.at
Mon Aug 28 20:24:01 UTC 2006


On Mon, Aug 28, 2006 at 01:16:42PM -0700, landley at busybox.net wrote:
>Author: landley
>Date: 2006-08-28 13:16:42 -0700 (Mon, 28 Aug 2006)
>New Revision: 16005
>
>Log:
>More allbareconfig fixes.

erm..
>
>
>Modified:
>   trunk/busybox/sysklogd/syslogd.c
>
>
>Changeset:
>Modified: trunk/busybox/sysklogd/syslogd.c
>===================================================================
>--- trunk/busybox/sysklogd/syslogd.c	2006-08-28 20:04:46 UTC (rev 16004)
>+++ trunk/busybox/sysklogd/syslogd.c	2006-08-28 20:16:42 UTC (rev 16005)
>@@ -247,6 +247,10 @@
> 	}
> 
> }
>+#else
>+void ipcsyslog_cleanup(void);
>+void ipcsyslog_init(void);
>+void circ_message(const char *msg);
> #endif							/* CONFIG_FEATURE_IPC_SYSLOG */
> 
> /* Note: There is also a function called "message()" in init.c */
>@@ -279,6 +283,7 @@
> 		fl.l_type = F_WRLCK;
> 		fcntl(fd, F_SETLKW, &fl);
> 
>+#ifdef CONFIG_FEATURE_ROTATE_LOGFILE
> 		if (ENABLE_FEATURE_ROTATE_LOGFILE && logFileSize > 0 ) {

Wasn't it exactly you who did want to get rid of preprocessor use?!

So why are you adding back in preprocessor stuff in elleged trivial cases like
this?

I admit that USE_ is broken for the next couple of years, since it is
not yet as wide supported as you may want, but it should be possible to
deal with this case in a somewhat sane manner even for compilers that
do not currently support varargs in the preprocessor..



More information about the busybox mailing list