[PATCH/RFC] readahead applet

Michael Opdenacker michael-lists at free-electrons.com
Mon Aug 21 09:21:39 UTC 2006


Rob Landley wrote:
> Agreed.
>
> However, some fixups:
>
> miscutils/conftest.c: what the?
>   
Oops, a weird issue after "make distclean". My fault. I don't have it 
anymore anyway.
> include/applets.h: has to be in alphabetical order.  I'll fix it.
> miscutils/Makefile.in: indentation is wrong.
>   
Thanks! I've seen that you already committed the fixes in svn. Thanks!
> miscutils/readahead.c:
>   Wouldn't "++argv; do { }while (*++argv)" be better as "while (*++argv) { }"?
>   If you ever have to typecast a 0, something is wrong.
>   The typecast implies that stat_buf.st_size isn't a size_t?  (We have an 
> fdlength() in libbb anyway.)
>   
Oops... Thanks a lot for your improvements!
Actually, some dead code is now left in svn. The attached patch fixes this.

You can also get this patch from 
http://free-electrons.com/pub/patches/busybox/svn/patch-busybox-svn15888-readahead-simplefix 

> Anyway:
>
> Applied.
>   
Excellent! Thanks again!

    :-)

    Michael.

-- 
Michael Opdenacker, Free Electrons
Free Embedded Linux Training Materials
on http://free-electrons.com/training
(More than 1000 pages!)

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch-busybox-svn15888-readahead-simplefix
Url: http://lists.busybox.net/pipermail/busybox/attachments/20060821/4cd23d0b/attachment.diff 


More information about the busybox mailing list