[PATCH] new applet: nmeter
Rob Landley
rob at landley.net
Sun Aug 20 23:04:36 UTC 2006
On Monday 07 August 2006 11:21 am, Denis Vlasenko wrote:
> Hello Rob,
>
> This is a resend. People raised some concerns/ideas about
> the applet which were addressed. For example, I did get rid
> of simple_itoa ;)
Ok, taking a closer look at this:
"Released under GPL", could I turn that into our boilerplate line? (Right now
this doesn't specify version, you may remember that came up recently. :)
S_STAT(): barf. You have a macro that defines the first _half_ of a
structure, and then you need a closed curly bracket after the macro. Your
macro contains an odd number of curly brackets. That's really, really ugly.
I don't care if the result is more lines of code, please unwrap that.
typdef ullong: not good. Would you rather this was uint64_t, or expanded
into "unsigned long long"? (Query: on 64 bit systems do you want this to be
128 bits?)
What does vrdval() do? It requires wrappers for variants of strtoull() in a
way that seems like an inline if statement would be simpler...
Copying the contents of /proc/meminfo into collect_mem() as a comment doesn't
seem helpful, somehow.
On the whole this looks like it could be cleaned up into something mergeable.
I need to do so when I haven't got a headache, though...
Rob
--
Never bet against the cheap plastic solution.
More information about the busybox
mailing list