[PATCH/RFC] readahead applet

Rob Landley rob at landley.net
Sun Aug 20 22:12:21 UTC 2006


On Sunday 20 August 2006 5:53 am, Bernhard Fischer wrote:
> On Sat, Aug 19, 2006 at 07:01:13PM +0200, Michael Opdenacker wrote:
> >Hello,
> >
> >The attached patch against busybox 1.2.1 adds a new "readahead" applet.
> 
> Sounds useful to me.

Agreed.

However, some fixups:

miscutils/conftest.c: what the?
include/applets.h: has to be in alphabetical order.  I'll fix it.
miscutils/Makefile.in: indentation is wrong.
miscutils/readahead.c:
  Wouldn't "++argv; do { }while (*++argv)" be better as "while (*++argv) { }"?
  If you ever have to typecast a 0, something is wrong.
  The typecast implies that stat_buf.st_size isn't a size_t?  (We have an 
fdlength() in libbb anyway.)

At this point I'm wondering if we should have another directory just for 
applets that busybox has but the rest of the world doesn't.  The original 
reason for the directories was to match the packages it was reimplementing, 
but we've wandered from that a bit...

> []
> >It may make sense to rename this applet to "readahead-list", to have the 
> >same name as in the standalone implementation.
> 
> I agree that the name should match the one of the already established
> "big" app.

The established "big" app reads file lists.  This one just uses its command 
line arguments (which is smaller).  I wouldn't copy the name of an app we're 
not copying the user interface of.

Anyway:

Applied.

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list