[PATCH] misc size-shrinkage; merges

Rob Landley rob at landley.net
Sat Aug 19 03:49:01 UTC 2006


On Friday 18 August 2006 11:53 am, Bernhard Fischer wrote:
> Hello,
> 
> Just a heads up..
> I plan to push the below patchset (split-up, of course) into my

Yes please.  (Reviewing 4000 lines at once ain't fun.)

> 'busybox_scratch' branch soonish, then merge that branch back into
> trunk.
> Unfortunately i have not yet setup a local git repo mainly because i
> didn't sit down and see what steps are needed to set that nifty tool up,
> i admit, so pushing that patch into the official svn will be a little
> bit of a pain for me..

I went with Mercurial because I find it simpler to set up and admin, it's 
faster, it's one project instead of 3 or 4, it's about 1/10th as much code 
(being written in Python will do that), and the on-disk file layout doesn't 
make by brain hurt.  But I have nothing against git. :)

I've pinged Junio and Matt about a bidirectional git-mercural converter that 
would allow each to pull from the other.  (They both say it's possible in 
theory...)  Apparently I wasn't the first to ask about this...

> The majority of the patch -- i.e. the libunarchival changes -- were
> provoked by a bug introduced by Rob when he added a function to xfuncs.c
> into an improper place and i managed to miss this simple fact early
> enough. Still these changes are ok to have, so i will not back them out.

What did I break?  (Any details on which function, and which bug?  With the 
amount of changes I've made over the past couple weeks, it's quite possible I 
broke stuff, I just can't tell what from the above, and the patch you 
attached is huge...)

> The rest (about 20 or 30 k) are simplifications of some coreutils
> applets and the ipc* applets, as can be seen in the diffstat below.

Woot.

> The current branch contains additional changes that saved (IIRC) a few
> hundred bytes, refer to svn for details.

Always a plus.

My current active projects this weekend are making autodocifier.pl go away, 
banging on mount a bit (there's a patch queued up that adds CIFS support), 
and getting the first drop of bbsh ready (I'm trying to get _something_ ready 
to check in soonish).  I have a couple other big things to do this weekend, 
but they're not busybox related.  So if you want to bang on the rest of the 
tree this weekend, we shouldn't bump into each other.

(I'm also pondering catching up on the rest of the patch backlog, but not just 
now.  I'm going to try to poke my boss to go back to the tuesday/thursday 
telecommuting thing as soon as the current big project's over and that'll 
help me catch up more than spending weekends on it.  I still have 500 or so 
things in the "pending" folder, plus bugs.busybox.net...)

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list