date -I bugs fixed in Re: [PATCH] misc size-shrinkage; merges

Bernhard Fischer rep.nop at aon.at
Fri Aug 18 16:19:01 UTC 2006


On Fri, Aug 18, 2006 at 05:53:59PM +0200, Bernhard Fischer wrote:
>Hello,
>
>Just a heads up..
>I plan to push the below patchset (split-up, of course) into my
>'busybox_scratch' branch soonish, then merge that branch back into
>trunk.
>Unfortunately i have not yet setup a local git repo mainly because i
>didn't sit down and see what steps are needed to set that nifty tool up,
>i admit, so pushing that patch into the official svn will be a little
>bit of a pain for me..
>
>The majority of the patch -- i.e. the libunarchival changes -- were
>provoked by a bug introduced by Rob when he added a function to xfuncs.c
>into an improper place and i managed to miss this simple fact early
>enough. Still these changes are ok to have, so i will not back them out.
>
>The rest (about 20 or 30 k) are simplifications of some coreutils
>applets and the ipc* applets, as can be seen in the diffstat below.

date -I was completely broken, that i remember for sure :)
Manually inlining the two functions did save an amazing amount (01k to
01m), but that last change is the only change that was not tested
beyond compilation, fwiw. So, if you have an affinity to date, i'd be
glad if you could give it a whirl.
$ size coreutils/date.o*
   text    data     bss     dec     hex filename
   1783       0       0    1783     6f7 coreutils/date.o.01a
   1737       0       0    1737     6c9 coreutils/date.o.01b
   1664       0       0    1664     680 coreutils/date.o.01c
   1660       0       0    1660     67c coreutils/date.o.01d
   1648       0       0    1648     670 coreutils/date.o.01h
   1639       0       0    1639     667 coreutils/date.o.01i
   1637       0       0    1637     665 coreutils/date.o.01j
   1622       0       0    1622     656 coreutils/date.o.01k
   1467       0       0    1467     5bb coreutils/date.o.01m


>
>The current branch contains additional changes that saved (IIRC) a few
>hundred bytes, refer to svn for details.




More information about the busybox mailing list