svn commit: trunk/busybox: archival coreutils include miscutils mod etc...

Bernhard Fischer rep.nop at aon.at
Tue Aug 15 13:37:16 UTC 2006


On Thu, Aug 03, 2006 at 10:58:17AM -0700, landley at busybox.net wrote:
>Author: landley
>Date: 2006-08-03 10:58:17 -0700 (Thu, 03 Aug 2006)
>New Revision: 15770
>
>Log:
>These should have been part of 15767 too.

this is not an appropriate log message.
You could as well have said that you're going to have dinner now.
Please let us keep log messages concise and explicit, TIA.

>Modified: trunk/busybox/modutils/lsmod.c
>===================================================================
>--- trunk/busybox/modutils/lsmod.c	2006-08-03 17:54:45 UTC (rev 15769)
>+++ trunk/busybox/modutils/lsmod.c	2006-08-03 17:58:17 UTC (rev 15770)
>@@ -12,18 +12,18 @@
>  */
> 
> #include "busybox.h"
>-#include <stdlib.h>
>-#include <stdio.h>
>-#include <string.h>
>-#include <stddef.h>
>-#include <errno.h>
>-#include <unistd.h>
>-#include <dirent.h>
>-#include <ctype.h>
>-#include <assert.h>
>-#include <getopt.h>
>-#include <sys/utsname.h>
>-#include <sys/file.h>
>+//#include <stdlib.h>
>+//#include <stdio.h>
>+//#include <string.h>
>+//#include <stddef.h>
>+//#include <errno.h>
>+//#include <unistd.h>
>+//#include <dirent.h>
>+//#include <ctype.h>
>+//#include <assert.h>
>+//#include <getopt.h>
>+//#include <sys/utsname.h>
>+//#include <sys/file.h>

What is the benefit in keeping these?
Please don't checkin such mess.. TIA.

>Modified: trunk/busybox/networking/dnsd.c
>===================================================================
>--- trunk/busybox/networking/dnsd.c	2006-08-03 17:54:45 UTC (rev 15769)
>+++ trunk/busybox/networking/dnsd.c	2006-08-03 17:58:17 UTC (rev 15770)
>@@ -208,8 +202,8 @@
> 	a.sin_family = AF_INET;
> 	if (!inet_aton(iface_addr, &a.sin_addr))
> 		bb_perror_msg_and_die("bad iface address");
>-	bb_xbind(s, (struct sockaddr *)&a, sizeof(a));
>-	listen(s, 50); /* bb_xlisten? */
>+	xbind(s, (struct sockaddr *)&a, sizeof(a));
>+	xlisten(s, 50); /* xlisten? */
> 	sprintf(msg, "accepting UDP packets on addr:port %s:%d\n",
> 		iface_addr, (int)listen_port);
> 	log_message(LOG_FILE, msg);

Please clean up the reminders/comments if you change stuff.




More information about the busybox mailing list