[RESEND IMPROVED PATCH ] [1.2.x] hdparm -S argument parsing broken

[Tito]

On Thursday 3 August 2006 07:06, Andre wrote:
> Tito <farmatito at tiscali.it> wrote:
> > On Wednesday 2 August 2006 11:57, Andre wrote:
> > > 
> > > # hdparm -S 180 /dev/hda
> > > 
> > > /dev/hda:
> > >  setting standby to 180 (15 minutes)
> > > 
> > > # busybox hdparm -S180 /dev/hda
> > > 
> > > /dev/hda:
> > >  setting standby to 180
> > > 15 minutes + 0 seconds)          <-- should be on previous line
> > > 
> >
> > Hi, this patch should fix the minor bug in command line  parsing
> > and the missing ( in the program output.
> > 
> > The patch is trivial and tested.
> > 
> 
> Works for me also... however I'm not sure it goes quite far enough.
> 
> Looking through source for hdparm 6.6, there are many other options
> which also generate warnings when used without an argument...
> 
> Therefore I think perhaps:
> 
> "S:D::P::X::K::A::L::W::CyYzZ"
> 
> should actually be:
> 
> "S:D:P:X:K:A:L:W:CyYzZ"
> 
> ???
> 
> Andre
> --
Hi,
This improved patch fixes also this problem spotted by Andre.

Please apply.

Ciao,
Tito
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hdparm_S_fix02.patch
Type: text/x-diff
Size: 534 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20060803/fa9825af/attachment-0002.bin