[PATCH] [1.2.x] hdparm -S argument parsing broken

Andre armcc2000 at yahoo.com
Thu Aug 3 05:06:59 UTC 2006


Tito <farmatito at tiscali.it> wrote:
> On Wednesday 2 August 2006 11:57, Andre wrote:
> > 
> > # hdparm -S 180 /dev/hda
> > 
> > /dev/hda:
> >  setting standby to 180 (15 minutes)
> > 
> > # busybox hdparm -S180 /dev/hda
> > 
> > /dev/hda:
> >  setting standby to 180
> > 15 minutes + 0 seconds)          <-- should be on previous line
> > 
>
> Hi, this patch should fix the minor bug in command line  parsing
> and the missing ( in the program output.
> 
> The patch is trivial and tested.
> 

Works for me also... however I'm not sure it goes quite far enough.

Looking through source for hdparm 6.6, there are many other options
which also generate warnings when used without an argument...

Therefore I think perhaps:

"S:D::P::X::K::A::L::W::CyYzZ"

should actually be:

"S:D:P:X:K:A:L:W:CyYzZ"

???

Andre
--


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 



More information about the busybox mailing list