[PATCH] hdparm 6.6 1/2

[Tito]

On Friday 28 April 2006 21:11, you wrote:
> On Friday 28 April 2006 7:40 am, Tito wrote:
> > Ok, fine.
> > Should we at least port the kernel headers stuff to the current svn.
> > If you agree I will rediff patch 04.
> >
> > hdparm66_kernelhdrs_04.patch for miscutils/hdparm.c
> >
> > to remove
> >
> > #include <linux/types.h>
> > #include <linux/hdreg.h>
> > #include <linux/major.h>
> > #include <asm/byteorder.h>
> >
> > from hdparm.c
> >
> > Let me know your opinion about it.
> 
> I'm neutral on it.  Doing copy and paste from headers doesn't make it any less 
> linux-specific.  It's unlikely to make it work on any system it didn't 
> already work on before.  To me the bigger issue is some way to mark the thing 
> "linux-specific" so the config can switch that off if people want to build 
> for macosx or libgloss or so on.
> 
> It already won't work on any environment where those headers are unlikely to 
> be there, would we prefer that it didn't work at build time or it didn't work 
> at runtime?

I just did it because i thought it was busybox's policy to never include
kernel headers.

In this particular case it is a good thing because it helps to reduce size.

Ciao,
Tito
> Rob