[PATCH] hdparm 6.6 1/2

Rob Landley rob at landley.net
Fri Apr 28 19:11:18 UTC 2006


On Friday 28 April 2006 7:40 am, Tito wrote:
> Ok, fine.
> Should we at least port the kernel headers stuff to the current svn.
> If you agree I will rediff patch 04.
>
> hdparm66_kernelhdrs_04.patch for miscutils/hdparm.c
>
> to remove
>
> #include <linux/types.h>
> #include <linux/hdreg.h>
> #include <linux/major.h>
> #include <asm/byteorder.h>
>
> from hdparm.c
>
> Let me know your opinion about it.

I'm neutral on it.  Doing copy and paste from headers doesn't make it any less 
linux-specific.  It's unlikely to make it work on any system it didn't 
already work on before.  To me the bigger issue is some way to mark the thing 
"linux-specific" so the config can switch that off if people want to build 
for macosx or libgloss or so on.

It already won't work on any environment where those headers are unlikely to 
be there, would we prefer that it didn't work at build time or it didn't work 
at runtime?

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list