[PATCH] hdparm 6.6

[Rob Landley]

Working my way through the backlog, I noticed your earlier 6.6 patch and 
rather than ask if that was a delta against the 6.3 one I put in on the 17th 
or it required the old one to be backed out, I thought I'd skip ahead and see 
if you'd reposted since...

On Thursday 20 April 2006 4:47 pm, Tito wrote:
> Hi,
> this patch upgrades bb's hdparm to
> the latest version 6.6.

It's 140k!  Eeep!  This is a 4357 line patch, and it's bigger than the 
existing hdparm code.

Um...  Is there any way to do this in smaller chunks?  There's no way I can 
review this tonight...

> The size of the applet with all config options enabled is:
>    text    data     bss     dec     hex filename
>   28950     928     916   30794    784a hdparm.o.6.6
>   27330         4     904   28238    6e4e hdparm.o.old
>
> The size increase is due mostly to the new functionalities added:

Mostly but not all?

> --direct  use O_DIRECT to bypass page cache for timings
> -E   set cd-rom drive speed
> -M   get/set acoustic management (0-254, 128: quiet, 254: fast)
> (EXPERIMENTAL)

As long as it's got its own config option, that's ok, but what's the size 
difference when the same set of options that the old one has is selected?

> The size of the applet with all optional features disabled is:
>
>   text    data     bss     dec     hex filename
>  10921       8     328   11257    2bf9 hdparm.o

vs 10580 bytes from the previous version.  What's the extra 350 bytes for?

> The dependencies on kernel headers were removed.
> The patch is big and could be downloaded from
>
> http://web.tiscali.it/sharp/hdparm6.6.patch.tar.gz
>
> Please apply if you think it is ok our you have a brave heart.

There's no way I can review 140k tonight...

> Ciao,
> Tito

Rob
-- 
Never bet against the cheap plastic solution.