[PATCH] fix format strings for intmax_t/uintmax_t

Atsushi Nemoto anemo at mba.ocn.ne.jp
Wed Apr 12 01:47:15 UTC 2006


On Tue, 28 Mar 2006 17:03:36 +0900 (JST), Atsushi Nemoto <anemo at mba.ocn.ne.jp> wrote:
> > I found busybox's stat command shows bogus value on some fields.  This
> > is due to mismatch of printing format string and intmax_t/uintmax_t.
> 
> I noticed this problem was already reported on bug tracking system (0000802).

Some part of this problem was fixed by commit 14755:

> Author: aldot
> Date: 2006-04-05 07:57:59 -0700 (Wed, 05 Apr 2006)
> New Revision: 14755
> 
> Log:
> - use proper macros to print intmax_t.
>   PRIuMAX and PRIxMAX are defined in inttypes depending on the wordsize.

But the commit is incomplete.  There are still some format strings to
fix.

And I think "j" modifier is better for readability.  It is C99 feature
and sum.c already use it.

aldot, could you take a look at my patch ?  This can be applied to
busybox 1.1.2 cleanly.

http://www.busybox.net/lists/busybox/2006-March/019760.html

Thanks.
---
Atsushi Nemoto



More information about the busybox mailing list