Busybox largefile patch
Tomasz Mateja
tommat at pimpek.one.pl
Thu Sep 29 11:43:15 UTC 2005
On Tue, 27 Sep 2005, Rob Landley wrote:
> On Tuesday 27 September 2005 12:04, Tomasz Mateja wrote:
>> Hi,
>>
>> I've made patch against 1.01 official release fixing problem with copying
>> large files (It resolved my problem with ftpput applet, but I think it is
>> more or less complete). Please review and/or apply.
>> Best regards.
>
> Cool. Needs a little bit of #ifdef consolidation cleanup but I can do that.
> A couple of questions:
>
> 1) You add safe_strtoll but never use it (instead strtoll is used). Why
> exactly is the normal strtoll unsafe?
I've made this to not have incomplete code there is safe_strtol and
safe_strtoul so it was done in similar way. There is used strtoll because
the base is 16.
>
> 2) Is there any point at which we care about the sign and thus do _not_ want
> to just use strtoull everywhere in this?
hmm I think that filesize cannot be <0 and we will have one bit more for
size :).
>
> 3) I take it this is not a backport of a 1.1 feature, but a new fix that
> should go into 1.1 as well?
Sure
--
Tomek
More information about the busybox
mailing list