[PATCH] mke2fs size reduction

Bernhard Fischer rep.nop at aon.at
Thu Sep 22 20:23:34 UTC 2005


On Thu, Sep 22, 2005 at 09:28:02PM +0200, Tito wrote:

>> Please use "-u" flag for diff.

>Ops,
>here it is.

-p would be nice too, if your diff has it.

Did you try to compile the e2fsprogs applets with CONFIG_DEBUG on?

>--- e2fsprogs/mke2fs_orig.c	2005-09-19 21:55:42.000000000 +0200
>+++ e2fsprogs/mke2fs.c	2005-09-22 21:25:58.000000000 +0200
>@@ -177,10 +177,7 @@
> 	FILE		*f;
> 	errcode_t	retval;
> 
>-	f = fopen(bad_blocks_file, "r");
>-	if (!f) {
>-		bb_perror_msg_and_die("Could not read bad blocks file %s", bad_blocks_file);
>-	}
>+	f = bb_xfopen(bad_blocks_file, "r");
> 	retval = ext2fs_read_bb_FILE(fs, f, bb_list, invalid_block);
> 	fclose (f);
> 	if (retval) {

here (in test_disk() ) is an alleged candidate for
{,UN}RESERVE_CONFIG_BUFFER(buf,1024)
[snip]
> 	if (fs->group_desc_count == 1) {
>-		printf("\n");
>+		puts("");
putc?
> 		return;
> 	}
> 
>@@ -644,7 +647,7 @@
> 		col_left -= need;
> 		printf("%u", group_block);
> 	}
>-	printf("\n\n");
>+	puts("\n");
putc?
> }
> 
> /*




More information about the busybox mailing list