[patch] make new parts of testsuite work via make check

Bernhard Fischer rep.nop at aon.at
Tue Sep 20 07:36:25 UTC 2005


On Mon, Sep 19, 2005 at 07:33:40PM -0500, Rob Landley wrote:
>On Sunday 18 September 2005 19:12, Bernhard Fischer wrote:
>> Hi,
>>
>> When i do  make check
>> i get ln:
>> creating symbolic link `links/uniq' to `../../busybox': No such file or
>> directory
>>
>> Attached patch fixes the new tests so they can be run via make check and
>> by going into the testsuite directory and issuing ./runtests
>
>I already made it so it'll work from runtest:
>
>svn diff testsuite/runtest -r 11312:11322
>
>Does it not work for you?

It doesn't:

someone at here:/scratch/obj/busybox# make check 2>&1 >&1 | egrep -v
"(PASS|FAIL)"
bindir=/scratch/obj/busybox srcdir=/scratch/obj/busybox/testsuite \
/scratch/obj/busybox/testsuite/runtest
ln: creating symbolic link `links/busybox' to `../../busybox': No such
file or directory
/scratch/obj/busybox/testsuite/runtest: line 105: ./busybox.tests: No
such file or directory
UNTESTED: hostid-works
UNTESTED: md5sum-verifies-non-binary-file
UNTESTED: msh-supports-underscores-in-variable-names
ln: creating symbolic link `links/sort' to `../../busybox': No such file
or directory
/scratch/obj/busybox/testsuite/runtest: line 105: ./sort.tests: No such
file or directory
UNTESTED: tar-handles-empty-include-and-non-empty-exclude-list
UNTESTED: tar-handles-exclude-and-extract-lists
UNTESTED: tar-handles-multiple-X-options
UNTESTED: tar-handles-nested-exclude
ln: creating symbolic link `links/uniq' to `../../busybox': No such file
or directory
/scratch/obj/busybox/testsuite/runtest: line 105: ./uniq.tests: No such
file or directory
UNTESTED: uuencode-sets-standard-input-mode-correctly
make: *** [check] Error 1


or directly:
someone at here:/scratch/obj/busybox/testsuite# ./runtest 2>&1 >&1 | egrep
-v "(PASS|FAIL)"
ln: creating symbolic link `links/busybox' to `../../busybox': No such
file or directory
UNTESTED: hostid-works
UNTESTED: md5sum-verifies-non-binary-file
UNTESTED: msh-supports-underscores-in-variable-names
ln: creating symbolic link `links/sort' to `../../busybox': No such file
or directory
UNTESTED: tar-handles-empty-include-and-non-empty-exclude-list
UNTESTED: tar-handles-exclude-and-extract-lists
UNTESTED: tar-handles-multiple-X-options
UNTESTED: tar-handles-nested-exclude
ln: creating symbolic link `links/uniq' to `../../busybox': No such file
or directory
UNTESTED: uuencode-sets-standard-input-mode-correctly


>
>Looking at the patch...
>
>Okay, I'd really rather _not_ introduce unnecessary environmental dependencies 
>on running these tests.  When it's run outside of make, $srcdir is not set.  

Hm? My copy of trunks runtest reads:
$ grep srcdir= runtest 
[ -n "$srcdir" ] || srcdir=$(pwd)

>We should not depend on srcdir being set.  I'd prefer making the dependency 
>on the current directory containing testing.sh more explicit, and having make 
>do a cd before trying to run it.
>
>It's _nice_ to be able to just run "COMMAND=../busybox ./busybox.tests".

I thought one is supposed to make check rather than executing every
single one of *.tests by hand, no?




More information about the busybox mailing list