[PATCH] dont compile pwd_to_spwd when shadow passwds is off

Amir Shalem amir at boom.org.il
Sat Sep 17 07:20:46 UTC 2005


On Sat, Sep 17, 2005 at 01:21:44AM -0500, Rob Landley wrote:
>> pwd2spwd is not a <shadow.h> function
>> and should be enabled even if !CONFIG_USE_BB_SHADOW.
>
>Yet it needs shadow.h in order to define its return type, so if shadow.h isn't 
>there (as in uclibc with that option switched off), then pwd2spwd.c won't 
>compile, correct?

assume CONFIG_FEATURE_SHADOWPASSWDS is on

if uclibc shadow support is off,
and user did not enabled busybox CONFIG_USE_BB_SHADOW,
all shadow users, those who include busybox/include/shadow_.h,
will fail.

but thats user fault,
because he disabled shadow support both in uclibc and busybox

the case which i'm trying to fix here,
is when user did not want any shadow support in busybox,
and therefor busybox should not compile any shadow program helpers (pwd2spwd)
pwd2spwd is used if and only if CONFIG_FEATURE_SHADOWPASSWDS is on.

>Are you saying that enabling CONFIG_USE_BB_SHADOW still requires shadow 
>password support in uClibc in order to compile?  If so, what's the point of 
>that option even existing?

no,
i'm saying that enabling CONFIG_USE_BB_SHADOW
still requires you to have pwd2spwd.c

pwd2spwd should be enabled only if CONFIG_FEATURE_SHADOWPASSWDS is on.

CONFIG_USE_BB_SHADOW lets you have shadow support within busybox programs
su, login, passwd, etc, without having shadow support in uclibc.

-- 
	Amir.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20050917/0a8410cc/attachment-0002.pgp 


More information about the busybox mailing list