[PATCH] dont compile pwd_to_spwd when shadow passwds is off

Amir Shalem amir at boom.org.il
Fri Sep 16 05:28:04 UTC 2005


On Thu, Sep 15, 2005 at 08:06:10PM -0500, Rob Landley wrote:
>On Thursday 15 September 2005 14:11, Amir Shalem wrote:
>> On Thu, Sep 15, 2005 at 01:26:05PM -0500, Rob Landley wrote:
>> >2) I just built allyesconfig minus shadow passwords and it built just
>> > fine, in both 1.01 (current subversion) and 1.1-pre.  What specific
>> > .config is failing for you?
>>
>> using busybox snapshot from 20050831:
>
>Download
>http://www.busybox.net/downloads/snapshots/busybox-20050831.tar.bz2
>Extract the tarball, cd into it...
>make allyesconfig
>make menuconfig, go into login menu, switch off CONFIG_FEATURE_SHADOWPASSWDS
>make
>
>It built fine.  How do I reproduce your problem?

like you said,
just dont forget to remove system <shadow.h> file:

  mv /usr/include/shadow.h /usr/include/shadow.h.tmp

since libc might not have shadow support.
and you will get the error I have reported in previous message.

the problem is that because pwd2spwd.c uses busybox/include/shadow_.h
and CONFIG_FEATURE_SHADOWPASSWDS, CONFIG_USE_BB_SHADOW are disabled

shadow_.h tries to use system <shadow.h> for the shadow structures.

pwd_to_spwd is only used when CONFIG_FEATURE_SHADOWPASSWDS is enabled
so its ok to disable its compliation when CONFIG_FEATURE_SHADOWPASSWDS is off

notice that if system has no shadow.h,
and user enables CONFIG_FEATURE_SHADOWPASSWDS,
he must enable CONFIG_USE_BB_SHADOW too.

if he doesn't, busybox will fail again, with similar error to mine,
but this time its user fault.

-- 
	Amir.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20050916/f36d6a2d/attachment-0002.pgp 


More information about the busybox mailing list