svn commit: trunk/busybox/archival

Vladimir N. Oleynik dzo at simtreas.ru
Mon Oct 17 08:46:28 UTC 2005


Rob,


> -# ifdef CONFIG_FEATURE_TAR_FROM
> -	if (exclude_file(tbInfo->excludeList, header_name)) {
> +	if (ENABLE_FEATURE_TAR_FROM &&
> +			exclude_file(tbInfo->excludeList, header_name)) {
>  		return SKIP;

Ohh. No. Do not convert #ifdef CONFIG_* to if(ENABLE_*) always before
check it. If try it without CONFIG_FEATURE_TAR_FROM we give
"warning (only) undeclared exclude_file()".
Also. Busybox must spare memory usage!
Result: "excludeList" must shadow from tbInfo if ENABLE_FEATURE_TAR_FROM=0,
and after this change we can`t compile with if(ENABLE_*) usage.


--w
vodz



More information about the busybox mailing list