[rfc] accumulating ifdef def else def endif in usage.h [was: Re: crond usage documentation oddity (busybox v1.1.0-pre1)]

Bernhard Fischer rep.nop at aon.at
Sat Oct 15 21:41:14 UTC 2005


On Sat, Oct 15, 2005 at 03:39:45PM -0500, Rob Landley wrote:
>On Saturday 15 October 2005 12:40, Bernhard Fischer wrote:
>> vodz> cow`: I like (may be my idea) #if ENABLE_FEATURE_*  #define
>> vodz>     USAGE_*(a) (a) #else #define USAGE_*(a) #endif :-)
>
>The general idea seems reasonable.
>
>> I'm attaching an untested quick patchlet which does this. What do other
>> people think about this approach (except that someone will dislike it
>> using awk and do it differently, which is fine with me)?
>
>I have no problem using awk as long as the script works with busybox awk.  I 

Didn't try that yet.. seems to work. oh and this awk invocation should
be $(AWK) where AWK ?= awk has to be added to Rules.mak to the mkdir and
other variables.

>much prefer that to a dependency on an external tool like perl. :)

awk, perl. It's all the same ;)
>
>Query about the name though: if you're going to tag generated files with a 

I don't care how it is named, that was a name that came quickly to my
mind "Private helper for usage".

>beginning underscore, shouldn't all of our generated files have such a tag, 
>including things like bb_config.h?

We could then add _*.h to .svnignore, or however it's called, instead of
enumerating them individually. I don't have an opinion on that naming
convention. Hm, otoh bb_config.h is the header for the applet bb_config,
iirc, so we may want to keep the name bb_config.h. Dunno.




More information about the busybox mailing list