[PATCH] e2fsck size reduction proposal

Tito farmatito at tiscali.it
Wed Oct 12 19:20:33 UTC 2005


On Wednesday 12 October 2005 19:21, Bernhard Fischer wrote:
> Hi Tito,
> 
> On Wed, Oct 12, 2005 at 04:46:12PM +0200, Tito wrote:
> >Hi,
> >this is a set of patches to reduce the size of e2fsck.
> 
> Just two small personal comments..
> 
> Patches are easier to review if you could generate them with diff -up
> i.e. also specify --show-c-fun aka -p
> That way one can see which function a specific hunk is touching.

I can rediff one for you but they get very big.......

> >01_applets_usage_exit_code.patch :
> >is trivial and should be applied as it could be useful in the future.

> On this one. nohup.c and at least one applet in coreutils set
> bb_default_error_retval. So please make sure that all other applets
> except e2fsprogs/* set bb_default_error_retval _after_ they would
> potentially call bb_show_usage. I didn't look if this is the case..

bb_default_error_retval is just before doing bb_show_usage 
or some *_error_and_die functions so this should not affect
other applets at all.

Ciao,
Tito
> cheers,
> Bernhard
> 
> 



More information about the busybox mailing list