[PATCH] e2fsck size reduction proposal

Vladimir N. Oleynik dzo at simtreas.ru
Wed Oct 12 15:50:16 UTC 2005


Hi, Tito.

> +	set_path();

May be e2fs_ prefix is more true.

-       buf = bb_xstrdup(opts);
+       buf = bb_xstrndup(opts, strlen(opts));

Why?

         lib_ver = ext2fs_get_library_version(0, &lib_ver_date);
         if (my_ver > lib_ver) {
-               fprintf( stderr, _("Error: ext2fs library version "
-                       "out of date!\n"));
+               bb_error_msg(_("ext2fs library out of date!"));

I think, this code may be full removed: e2fs library is internal
and can`t out of date ;-)

-       if (argc && *argv)
-               ctx->program_name = *argv;
-       else
-               ctx->program_name = "e2fsck";
+       ctx->program_name = bb_applet_name;
+

Also candidate for removed ;-)


--w
vodz



More information about the busybox mailing list