[BusyBox] Re: [PATCH] zcip for busybox (rfc3927) size optimization

Jason Schoon floydpink at gmail.com
Wed May 11 20:48:23 UTC 2005


While I agree that changes for style cause patches to be unnecessarily
large, I disagree that uppercase defines are harder to read.

I prefer uppercase for defines because I want them to be noticably
different than compiled code.  I hate searching through code, missing
a hidden define, only to learn that the code I'm analyzing isn't even
currently active.

Just my thoughts...

On 5/11/05, David Brownell <david-b at pacbell.net> wrote:
> On Saturday 07 May 2005 12:50 pm, Tito wrote:
> > Hi,
> > this a new attempt to optimize the size of the zcip applet.
> > This time i've put maximun effort into making the life
> > of the mantainer as easy as possible, so the code
> > is mostly untouched and size reduction is achieved
> > through preprocessor misuse.
> > This so far is just a proof of concept and is totally
> > untested.
> 
> Thanks, I'll have a look.  One thing you might consider
> when doing this sort of stuff is that there's no rule
> that preprocessor symbols must be in uppercase.  A lot
> of the size of this patch comes from having more or
> less pointlesslly changed symbol cases.
> 
> CODE THAT SHOUTS AT YOU IS HARDER TO READ.  Even Fortran
> doesn't expect that any more.  :)
> 
> - Dave
> 
> 
> _______________________________________________
> busybox mailing list
> busybox at mail.busybox.net 
> http://busybox.net/mailman/listinfo/busybox
> 
> 
>



More information about the busybox mailing list