[BusyBox] tail: dprintf [PATCH]
Rob Landley
rob at landley.net
Sat May 7 06:51:08 UTC 2005
On Wednesday 06 April 2005 02:25 pm, Shaun Jackman wrote:
> tail uses the non-portable dprintf to test for an output error. A
> portable alternative is to check the return values of printf and
> flush. In this case where a stream is readily available for the file
> descriptor, I prefer this patch, but an alternative is to provide an
> implementation of dprintf in libbb as is already done for vdprintf.
>
> Cheers,
> Shaun
You're right, dprintf(STDOUT_FILENO,...) is a pointless obfuscation of a
normal printf.
Applied.
Rob
More information about the busybox
mailing list