[BusyBox] ftpget and ftpput problems with Windows FTP servers [*long*]

[Nicolas Zampieri]

Thanks for the reply....

How can I compile this code to run on my WRT54g v1.1?

Thanks,
NIck

>From: Rainer Weikusat <rainer.weikusat at sncag.com>
>To: "Nicolas Zampieri" <bullmoose20 at hotmail.com>
>CC: busybox at mail.codepoet.org
>Subject: Re: [BusyBox] ftpget and ftpput problems with Windows FTP servers 
>[*long*]
>Date: Thu, 02 Jun 2005 17:33:41 +0200
>
>"Nicolas Zampieri" <bullmoose20 at hotmail.com> writes:
> > I have a linksys wrt54g v 1.1 router running Sveasoft's Alchemy 1.0
> > released firmware. I am trying to use the ftpput and ftpget commands
> > to backup some files that i have on the router to my PC on my home
> > network. On there is Busybox 1.0.
> >
> > I have tried warftpd, cerberusftp, goldenftp, and netfserver on my
> > Windows XP SP2 pc and all of them gave me the same result. I was
> > unable to connect to the ftp server. The only ftp server that gave me
> > some errors is Cerberus and it is leading me to believe that the
> > ftpput and ftpget is using an "improperly formatted string".
>
>The ftp*-code is a pile of junk whose output/ interaction with other
>machines only remotely resembles FTP as specified by RFC959. The patch
>below (against SVN/ yesterday) fixes/ changes the following issues:
>
>	- improper use of \n as line separator instead of \r\n (that's
>           most likely what you had problems with)
>
>	- spurious use of non-standard command (SIZE) in the
>           download-path
>
>	- don't print (NULL)(NULL) in verbose mode if no command was
>           sent
>
>	- print FTP server replies alongside FTP client requests in
>           verbose mode
>
>	- use ALLO on request in put-codepath (some servers don't
>           implement it or implement it wrongly), not forcibly
>
>	- don't try to CWD to the destintation filename (!) when
>           putting
>
>	- local and remote filenames are used as naive people would
>           expect (ie to specify remote and local filenames, not the
>           other way round).
>
>	- handle error and non-error paths consistently in FTP actions
>
>         - never close local file descriptors before exiting
>
>	- don't use { } for single-line if statements
>
>         - don't double-format FTP requests because of forced %s for
>           requests taking numeric arguments
>
>         - some structural/ cosmetic changes that I like better than
>           the orignal code
>
>The resulting code is probably somewhat larger than the
>original.
>
>Standard Disclaimer: I do not care to get my name written down
>anywhere, I just need to be able to use the code. Feel free to fix any
>bugs you may find yourself (tell me about them if you feel like being
>nice).
>
><< ftp.diff >>