[BusyBox] pre-commit feedback, please

[Mike Frysinger]

On Thursday 28 July 2005 05:44 pm, Paul Fox wrote:
> 0000003 03-16-05 [PATCH] Do not export all make variables
>     [ submitter pkj was going to commit this.  see also bug #94 ]

a quick test shows that this works fine ... add it to 1.1 for sure and see 
what breaks :)

> 0000028 03-16-05 patch: new setsid applet
>     [ my bug/patch -- i hope this is non-controversial ]

i'd like this applet as well ... add it to 1.1 assuming you clean it up a bit 
(syntax, change perror to a libbb error function, etc...)

> 0000046 03-16-05 Config Applet
>     [ new applet -- displays busybox config options.  i'm not sure i
> 	understand why this is needed.  ]

if it works i'd say add it to 1.1 ... not like it'd hurt anyone ... also, why 
does the linux kernel offer /proc/config.gz ?  because for some reason, some 
people like that sort of thing

> 0000072 03-16-05 Add applet to redirect console output via ioctl(...,
> TIOCCONS) [ looks okay to me ]

i'd call the applet 'setconsole' since there's already a package out there 
that SuSe uses ... they dont act the same but they pretty much behave the 
same

> 0000094 03-16-05 Busybox 'make install' does not respect PREFIX when using
> O= [ see also bug #3 -- if everything's exported, why is this needed? ]

KBUILD_OUTPUT has always confused ... if it doesnt break anything, toss it in
-mike