[BusyBox] Re: [BusyBox-cvs] svn commit: trunk/busybox: include networking

[Rob Landley]

On Thursday 28 July 2005 12:23, Ladislav Michl wrote:
> On Thu, Jul 28, 2005 at 11:46:50AM -0500, Rob Landley wrote:
> > P.S.  I got an email from Erik yesterday that says he's gone fishing
> > until saturday.  I'm going to try to get this resolved, and also prepare
> > an -rc2 and check in my mount rewrite by then, so he can review it all
> > when he gets back.
>
> Hi,
>
> I was unable to find patch you are talking about (didn't try too hard)
> and I'd like to ask you to at least apply this one in case you won't
> check your rewrite in:

The last time the mount patch was posted to the list was:

http://www.busybox.net/lists/busybox/2005-May/014393.html

(Keep in mind the attachment URL should go to busybox.net, not codepoet.org).

I have no idea if that still applies.  I also know that version's not finished 
(the mount side might be, I don't remember.  But umount isn't.)

> Index: util-linux/mount.c
> ===================================================================
> --- util-linux/mount.c (revision 10941)
> +++ util-linux/mount.c (working copy)
> @@ -418,17 +418,6 @@
>    show_mounts(got_filesystemType ? filesystemType : NULL);
>   }
>
> - if (optind < argc) {
> -  /* if device is a filename get its real path */
> -  if (stat(argv[optind], &statbuf) == 0) {
> -   char *tmp = bb_simplify_path(argv[optind]);
> -
> -   safe_strncpy(device, tmp, PATH_MAX);
> -  } else {
> -   safe_strncpy(device, argv[optind], PATH_MAX);
> -  }
> - }
> -
>   if (optind + 1 < argc)
>    directory = bb_simplify_path(argv[optind + 1]);
>
>
> Why does such check exist at all? It seems pretty broken to me. Imagine
> you want to do 'mount -t jffs2 mtd1 /mnt' while in /dev directory.
> Device name gets expanded to /dev/mtd1, which is character device and
> mount will fail.

*blinks*

Ok, so what did you _expect_ to happen?

> Btw, 'mount -t jffs2 mtd:partname /mnt' will fail as 
> well, because device containing ':' is considered to be NFS server, but
> that's another issue...

That's an interface issue, really.  I've largely left the NFS stuff alone 
because I don't use it...

>  ladis

Rob