[BusyBox] Re: ifconfig: Clean up. [PATCH]

Rob Landley rob at landley.net
Wed Jul 27 07:08:47 UTC 2005


On Tuesday 26 July 2005 19:03, Glenn L. McGrath wrote:

> > and why do we care about closing file descriptors?
>
> We should be closing and checking the return value of close. I was going
> to jump on this problem at one time for the archiving code, but i never
> got around to it.
>
> From man close(2)
>
> "Not checking the return value of close is  a  common  but  nevertheless
> serious  programming error.  It is quite possible that errors on a
> previous write(2) operation are first reported at the  final  close.
> Not checking the return value when closing the file may lead to silent
> loss of data.  This can especially be observed with NFS and with disk
> quota."

Wanna add it to the TODO list in svn?

Rob



More information about the busybox mailing list