[BusyBox] Re: ifconfig: Clean up. [PATCH]

[Shaun Jackman]

On 7/26/05, Rainer Weikusat <rainer.weikusat at sncag.com> wrote:
> > If CLEAN_UP is undefined, it shouldn't affect the binary size at
> > all.
> 
> This depends on the compiler that is used and on the way it is
> called, ie this is a really ugly hack. Actually, it even (assuming
> gcc) depends on undocumented features of this compiler.

If you're referring to the use of if(xxx) instead of #if xxx, the
original patch I posted used the preprocessor, but it met some
resistance because the latter style uses three lines, whereas the
former uses only one line. Additionally, the Linux kernel uses the
former style.

I wouldn't call if(xxx) an ugly hack though. Dead code elimination is
a fairly standard optimization.

I'm somewhat ambivalent, or more to the point, currently undecided as
to which I personally prefer.

Cheers,
Shaun