[BusyBox] Re: ifconfig: Clean up. [PATCH]

[Rob Landley]

On Monday 25 July 2005 00:28, Shaun Jackman wrote:
>
> An idea entered my mind...
>
> /* Uncomment one of these. */
> /* #define CONFIG_FEATURE_CLEAN_UP 1 */
> /* #undef CONFIG_FEATURE_CLEAN_UP */
> #ifndef CONFIG_FEATURE_CLEAN_UP
>   const int CONFIG_FEATURE_CLEAN_UP = 0;
> #endif

Uh-huh.  Are you volunteering to rewrite make menuconfig, maintain your own 
version separate from the linux version we periodically resync with, and 
explain to anybody out there who has tools that synthesize linux-format 
config files that our stuff has stopped behaving like the linux kernel's 
config system?

Rob



> I'd to spell do_cleanup as DO_CLEANUP. If I saw...
>  if (DO_CLEANUP)
> ... I'd understand it was a conditional compilation. If I saw...
>  if (do_cleanup)

I was actually thinking of a static const int.

> ... I'd start looking for the definition of do_cleanup and where it
> was last modified.

And since it's a global, you'd look in the header files.  Are you implying you 
wouldn't find it?

(Sorry, I'm not arguing for arbitrary semantics, I'm arguing for basically the 
same semantics as the linux kernel uses...)

Rob