[BusyBox] Re: ifconfig: Clean up. [PATCH]

Rob Landley rob at landley.net
Mon Jul 25 01:50:39 UTC 2005


On Sunday 24 July 2005 12:32, Shaun Jackman wrote:
> Ping?
>
> -- sdj

Hmmm...

The problem is I really hate adding extra #ifdefs, especially for something 
that small.  For 1.0.1 this doesn't really need to be addressed at all, and 
for 1.1 what would be really nice would be a general reorganization where we 
have libbb.h have one #ifdef that set "do_cleanup" to 0 or 1, and then we 
used if(do_cleanup) in the body of the code and let the compiler's dead code 
elimination yank it for us...

Opinions?

P.S.  I just applied the ping.c patch.  Looking at the others now.  Still 
trying to put -rc2 together...

Rob



More information about the busybox mailing list