[BusyBox] [PATCH] fix compilation of libbb/mtab_file.c

Arthur Othieno a.othieno at bluewin.ch
Fri Jul 22 23:21:09 UTC 2005


On Fri, Jul 22, 2005 at 12:46:29AM -0500, Rob Landley wrote:
> On Wednesday 20 July 2005 16:23, Arthur Othieno wrote:
> 
> > CONFIG_FEATURE_MTAB_FILENAME removed with this change:
> > http://busybox.net/cgi-bin/viewcvs.cgi/trunk/busybox/util-linux/Config.in?r
> >ev=10556&r1=10350&r2=10556
> >
> > Reverted here:
> > http://busybox.net/bugs/view.php?id=322
> 
> What's the issue here?  (Why do you want /etc/mtab at a nonstandard location, 
> and can't symlink it?  I'd like to point out that /etc/mtab _is_ listed in 
> the FHS 2.3.  It's "optional", but if you have it they say where it should 
> be.)
 
Hey, revision 10556 removed CONFIG_FEATURE_MTAB_FILENAME without _no_
mention of it. The log in question reads:

  Rodney Radford submitted ipcs and ipcrm (system V IPC stuff).  They could use
  some more work to shrink them down.

Re-defining it was only out of the impression that it was removed
by accident.

Now, after sifting through <busybox-cvs at busybox.net> archives,
I gather the original intent was to do away with this entirely:
http://www.busybox.net/lists/busybox-cvs/2005-May/005736.html

In that case, this patch is more correct:


Index: libbb/mtab_file.c
===================================================================
--- libbb/mtab_file.c	(revision 10900)
+++ libbb/mtab_file.c	(working copy)
@@ -26,7 +26,7 @@
 /* Busybox mount uses either /proc/mounts or /etc/mtab to
  * get the list of currently mounted filesystems */
 #if defined CONFIG_FEATURE_MTAB_SUPPORT
-const char bb_path_mtab_file[] = CONFIG_FEATURE_MTAB_FILENAME;
+const char bb_path_mtab_file[] = "/etc/mtab";
 #else
 const char bb_path_mtab_file[] = "/proc/mounts";
 #endif



More information about the busybox mailing list