[BusyBox] Grinding through the patch list for 1.0.1...

Rob Landley rob at landley.net
Thu Jul 14 05:57:13 UTC 2005


I'm about halfway through the list of patches for 1.0.1 (i've categorized from 
9416 to 10165; the most recent is 10723 so I've still got a ways to go), and 
I'd like to bring up an issue regarding svn changesets 10137 and 10165:

Putting whitespace between # and define is NOT an improvement over indenting 
the #define.  Really, it isn't.  Honest and truly.

Just had to get that out of my system...

Rob

(P.S.  For the curious, my categorization so far is attached.  It's not done 
yet...)
-------------- next part --------------
The stable repository was cloned at 9416.  These following are 1.0 material:

9486: Sed bugfix.
9487: Authors update.
9497: Makefile fix.
9517: bunzip fix.
9530: Sed bugfix.
9569: gzip cleanup.
9849: gzip compile fix for gcc 4.0
9869,9870: whitespace
9950: gzip bugfix.
9951: gunzip bugfix.
9971,9973: Syscalls tweak.
10061, 10062: insmod bugfixes.
10073: sysklogd fix.
10102: getty bugfix.
10111: Initializer tweak.
10112: usage fix.
10113: Strict ansi compliance.
10114: Whitespace/style issues.
10115: grep bugfix.
10117: copyfd fix (fixes cat).
10119: Macro fix.
10120: Make init suck slightly less.  (needs a complete rewrite in 1.1)
10121: Make lots of globals static.
10134: getopt_ulflags comments.
10135: update scripts/config to match linux 2.6.11.
10138: tweak error message.
10139: makefile typo.
10145: type in AUTHORS
10150: busybox help to stdout, not stderr
10153: Make warning in who go away.
10156: documentation update.
10164: whitespace cleanup

These are new features, which belong in 1.1:

9766,9871: the new to-do list.
9418: makefile O= and PREFIX= support.
9542: readlink -f.
9767,9768: Sort rewrite.
9837,9838: ash read -t (timeout) support.
9868: nice (and renice rewrite).
9969,9970,9972: Support for some random closed source libc.  (Why include this?)
10096: test (add [[ and == support)
10097: cp -H, -L
10123, 10133, 10154: fakeidentd
10147,10152: printenv (also known as "set with no arguments"...)
10148, 10149: sum
10160: ed (does anybody _use_ ed???)
10163: stat

Probably yes, but I have questions:

9539: Insufficient description.  (Is it a bug fix?)
9620: What's with "$ident"?
9545, 9633, 9641: loop.c is cursed.  What does the #ifdef accomplish?
9650: Is this a new feature, or a bugfix?
10109: This workaround for a clearly broken closed-source compiler doesn't
       even say _which_ compiler...
10116: Does anything actually use this?
10118: What's the issue here?
10155: Don't comment warnings, _fix_ warnings.
10159: how the heck do I move this one over?

The following touch the web pages.  We should just grab the new ones or
something.
9447, 9472, 9573, 9697, 9700, 9704, 9787, 9821, 9822, 9823, 9834, 9922,
10064, 10122, 10124

This is just wrong:
10137, 10165: A space between # and define is not an improvement.

Obsolete (noise):
10151, 10157, 10158


More information about the busybox mailing list