[PATCH]passwd: size reduction and clean up

Mike Frysinger vapier at gentoo.org
Thu Dec 29 13:15:33 UTC 2005


On Thursday 29 December 2005 08:13, Vladimir N. Oleynik wrote:
> Mike Frysinger wrote:
> > On Thursday 29 December 2005 07:27, Vladimir N. Oleynik wrote:
> >>>-			fprintf(stderr, "Incorrect password.\n");
> >>>+			bb_error_msg("Incorrect password.");
> >>>-		fprintf(stderr, "Passwords do not match.\n");
> >>>+		bb_error_msg("Passwords do not match.");
> >>
> >>May be best if not change this?
> >
> > why ?
>
> The Passwd utulity is unlike nonterminal. For hack this many people
> using "expect". bb_error_msg("eror_msg") produce "utility_name: error_msg"
> and unexpect for "expect" ;-)

then a comment should be thrown above those lines like:
/* do not use bb_error_msg() as the output should not contain the program name 
for the sake of scripting utilties */

that way people wont keep trying to "fix" the output
-mike



More information about the busybox mailing list