Houston, we have warnings.

[Bernhard Fischer]

On Wed, Dec 14, 2005 at 06:10:10AM -0600, Rob Landley wrote:
>On Tuesday 13 December 2005 05:03, Bernhard Fischer wrote:
>> On Tue, Dec 13, 2005 at 11:59:47AM +0100, Bernhard Fischer wrote:
>> >On Mon, Dec 12, 2005 at 10:08:07PM -0600, Rob Landley wrote:
>> >>/home/landley/busybox/busybox/networking/ifupdown.c:306: warning:
>> >> `execute' defined but not used
>> >
>> >I have the attached *untested* snippet in my tree... please ci if your
>> >testing shows that it is ok, TIA.
>>
>> forgot to paste this, fwiw:
>> $ size networking/ifupdown.o*
>>    text    data     bss     dec     hex filename
>>    4272       0       8    4280    10b8 networking/ifupdown.o
>>    5150       0      28    5178    143a networking/ifupdown.o.oorig
>>
>> cheers,
>
>Seems pretty straightforward, you're #ifdeffing out stuff that the compiler is 
>too blitheringly stupid to figure out never gets called.  (It's marked 
>static, right?  And still compiled in without the #ifdef?  Bravo, gcc...)
>
>What's to test?  What potential downside here wouldn't just be a build break?

Yes, buildtest (did that for the above numbers) should be sufficient, so
i'll check it in.