[BusyBox] [patch] new applet mountpoint

Bernhard Fischer rep.nop at aon.at
Fri Aug 19 16:30:46 UTC 2005


On Fri, Aug 19, 2005 at 11:01:53AM -0500, Jason Schoon wrote:
>Wow, I hate to jump into the middle of a firefight, but so be it.

No firefight as far as i'm concerned, just criticism, which is welcome,
at least from my part :)

[]
>This seems like a small and at least somewhat common system utility. 
>Exactly what I associate with Busybox.
>
>Now, if your argument is poor code, choose that rather than simply
>stating this could be written a different way.  Moreover, why not
>simply state issues that you see and/or post an updated patch, rather
>than falling to pure accusations such as "needlessly
>inefficient (pointless memory allocations)".

We're just doing doing that.

I replaced the strerror line proper with
bb_perror_msg_and_die("%s", arg);
and also put that single char instead of silly printf'ing. Saves 50
bytes. See? he's right :)




More information about the busybox mailing list