[BusyBox] I am new and I would know how to...

Rob Landley rob at landley.net
Fri Aug 12 03:24:47 UTC 2005


On Thursday 11 August 2005 07:42, Mike Frysinger wrote:
> On Thursday 11 August 2005 05:05 am, Roberto A. Foglietta wrote:
> >   but I did not receive any comments or confirm.
>
> we'll get to it eventually ;)
>
> >   I do not thik it a important one but simply I am wondering if I was
> > wrong in doing something.
>
> in general you seem to declare local variables when they arent really
> needed ... that just adds overhead most of the time
>
> also, your extract_cpio_gz function changes are incomplete, some places
> still declare it as void ...
> -mike

I just looked at it.  It's a good patch, needs a bit of cleanup (the return 
value of the transformer might as well be what we exit with) but I can do 
that.

Of course somebody might get to this before I get back online to check this 
in... :)

Rob



More information about the busybox mailing list