[BusyBox] Re: [patch] zcip for busybox (rfc3927)
David Brownell
david-b at pacbell.net
Mon Apr 18 20:22:08 UTC 2005
On Monday 18 April 2005 12:53 pm, Bernhard Fischer wrote:
> >--- networking/Config.in (revision 10132)
> >+++ networking/Config.in (working copy)
> >@@ -637,5 +637,16 @@
> []
> >+ ZCIP provides ZeroConf IPv4 address selection, according to RFC 3927.
> >+ It's a daemon that allocates and defends a dynamically assigned
>
> I'm not sure what "defends" means here. Does it also implement a flamethrower,
> or should this read defines? Please eventually add a sentence to the
> help-text which explains this probably minor detail.
If there were a setsockopt(fd, SO_FLAMETHROWER, ...) I might consider
using it in a few other places ... ;)
But here, it's just the mechanism named and described in the RFC.
> Some seem to not build the examples, but please provide a simple one
> nevertheless.
Attached ... two files: (bb-0418b.patch) the example I meant to include
before, "svn diff" didn't tell me I forgot it, and (zcip.sh) a simple init
script, which seemed maybe inappropriate to put into the "examples"
directory given the general lack of similar stuff in BusyBox (and also
the fact that I think more work on system integration is needed).
> >+// TODO:
> >+// - more real-world usage/testing, especially daemon mode
> >+// - kernel packet filters to reduce scheduling noise
> >+// - avoid silent script failures, especially under load...
> >+// - link status monitoring (restart on link-up; stop on link-down)
>
> please let's put either std=c99 in by default or convert the non-warnings
> (like the above) to /* XXX: TODO\nwhatever */
I have no idea what you mean by this. Are you suggesting that
for some reason "// ..." style comments are undesirable? They've
been supported on most compilers for the past dozen years or more,
and the busybox docs I saw didn't mention any such issue.
- Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zcip.sh
Type: application/x-shellscript
Size: 1148 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20050418/2907e56e/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bb-0418b.patch
Type: text/x-diff
Size: 857 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20050418/2907e56e/attachment-0001.bin
More information about the busybox
mailing list