[BusyBox] Re: static

[Erik Andersen]

On Sat Apr 16, 2005 at 09:21:08PM +0200, Bernhard Fischer wrote:
> On Fri, Apr 08, 2005 at 09:43:12AM +0200, Bernhard Fischer wrote:
> >On Thu, Apr 07, 2005 at 11:13:48AM -0700, bugs at busybox.net wrote:
> >>
> >><http://busybox.net/bugs/view.php?id=218> 
> >
> >>Summary:                    Patch to zcip applet for arm-elf
> >>Description: 
> >>The function called "run", internal to the zcip applet, is not set as
> >>static. As a consequence, a bug in the arm-elf will link zcip calls to
> >>"run" to the function defined by the "init" module. zcip relies upon this
> >>function to call the scripts it needs to set up networking. The fix is
> >>very simple but I've attached the patch.
> >
> >To me, it seems there are several places which ought to be static.

Perhaps so, but as to bug 218, there is no zcip applet in BusyBox.
Must be some vendor local thing...

> >
> >http://members.aon.at/berny_f/busybox/busybox.statics.1.diff
> >Compile tested.
> >Comments?
> 
> Could some kind soul please review this and apply it?
> Please let me know if i should put this into the BTS instead, thank you.

Patches really should be vs the current SVN tree, but I've
cleaned up the rejects and merged your patch.  It is indeed
best to keep the global namespace clean.

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--