[BusyBox] init syslog messages have ^M

Vladimir N. Oleynik dzo at simtreas.ru
Thu Nov 25 13:38:53 UTC 2004


Hiroshi,

>>But I think, at least when SYSLOG is enabled, we do not need
>>to put a log to console.
>>that is why I did not send this patch.
> 
> 
>   It was not correct.
> 
>   I checked source again.
>   My patch just do ad-hoc way. so please forget above.
>   (but, my patch was enough for me.)
> 
>   I think removing '\r' is better way, as you think.

No. The message() function used for
1) start messages
2) fatal problems
3) shutdown messages
its points can show to console.
3 point usually used with "\r" to console.
I think, the patch
- syslog(LOG_INFO, "%s", msg);
+ syslog(LOG_INFO, "%s", msg + 1);
is more correct.
This block code is my changes and I have forgoted "+ 1" only.


--w
vodz




More information about the busybox mailing list