[BusyBox] Bug in syslogd.c

Glenn McGrath bug1 at iinet.net.au
Thu Jul 22 04:34:02 UTC 2004


On Wed, 21 Jul 2004 21:59:48 -0400
"Stephane Billiart" <stephane at reefedge.com> wrote:

> On 21/07/04 ? ? 23:07, Glenn McGrath wrote:
> > On Wed, 21 Jul 2004 14:27:52 +1200
> > "Richard Laing" <Richard.Laing at 4rf.com> wrote:
> > 
> > > There appears to be a bug in the rc1 version (and previous
> > > versions) with setting the size of the circular buffer. It always
> > > gets the default size of 16K. The following patch appears to fix
> > > the problem.
> > 
> > Applied
> 
> This patch made CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE useless since -C
> now requires an argument.
> 
> I don't think this was a bug: I don't need to change the buffer size
> that often and I preferred the old behaviour with the buffer size set
> at compile time and -C being just a switch to turn circular buffering
> on.
> 
> Can you consider the attached patch against the current CVS version?
> Otherwise I guess we can drop CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE
> from the config file and syslogd.c.
> 
> Comments welcome.

Ive reversed my patch and left it how it was, it looks to me like a
glibc bug, not a busybox bug.

"::" is supposed to be a GNU getopt extension to make the argument
optional, it seems to me that getopt is just ignoring the argument.

xargs -e is in a similar situation.



Glenn



More information about the busybox mailing list