[BusyBox] enhanced cmdedit
Glenn McGrath
bug1 at iinet.net.au
Tue Jan 20 20:44:47 UTC 2004
On Tue, 20 Jan 2004 14:14:23 -0500
Paul Fox <pgf at brightstareng.com> wrote:
> can someone comment on how patches are evaluated against
> busybox's goals?
Producing a small binary is very much the main goal of busybox, but
other factors need to be considered.
Factors i generally consider when considering patches.
- Is it good quality code, safe, maintainable.
- Does it fix more problems than it introduces.
- Does it reduce size, add features, or both :)
If it needs work it may still be acceptable, depending on other factors
such as.
- How active the submitter is, is it likely that any problems will be
fixed in future patches.
- How isolated the code is, if the code is a bit bloated, but it adds a
new requested feature that doesnt adversly effect anyone else then it
may be ok.
Some code needs time to mature, its hard to make it perfect the first
time. Opinions differ, but i think it can be better to have a
non-optimised version in cvs as a work in progress than nothing at all,
that way its easier for multiple people to work on it.
Glenn
More information about the busybox
mailing list