[BusyBox] [PATCH] ifndef PAGE_SHIFT
Stewart Brodie
stewart at metahusky.net
Mon Jan 19 10:01:36 UTC 2004
Re-starting a conversation that started on 20th December last year ...
[Recent MIPS kernels (about 2.4.23 onwards) do not make PAGE_SHIFT or
PAGE_MASK available to userland, the macros in asm-mips/page.h now being
protected inside #ifdef __KERNEL__ - but libbb/procps.c relies on PAGE_SHIFT
being available - possibly other things do too. Erik put a definition in
libbb/procps.c in for PAGE_MASK instead of PAGE_SHIFT, Atsushi Nemoto
queried this, Erik admitted he couldn't read :-), and removed the PAGE_MASK
but never did insert the PAGE_SHIFT definition]
Atsushi Nemoto >>> Why? The procps.c needs PAGE_SHIFT, not PAGE_MASK.
Erik Andersen >> I realized this later... Apparently I can not read... ;-)
Atsushi Nemoto > Then, could you fix it, please?
The fix was applied in revision 1.11 of procps.c, which was to remove the
definition, so we were back to the same as revision 1.8 - which means we are
back where we started where libbb/procps.c won't compile for MIPS.
Please could we have this definition put in properly? I couldn't see
anything wrong with the patch Atsushi Nemoto posted to the list initially
anyway.
--
Stewart Brodie
More information about the busybox
mailing list