[BusyBox] Re: login buggy also in 1.00pre5

Charlie Brady charlieb-busybox at e-smith.com
Tue Jan 6 22:22:11 UTC 2004


On Tue, 6 Jan 2004, Tito wrote:

> > > 	if ( check_nologin ( pw-> pw_uid == 0 ))
> > > 		return EXIT_FAILURE;
...
> maybe something like :
>  	if ( check_nologin ( (pw-> pw_uid == 0) ) == 1)
>  		return EXIT_FAILURE;
> would be easier to understand for the non-gurus. ;-)

But that might mean something different (the internals of 
check_nologin() will say).

Would you be happier with

if (check_nologin(!pw->pw_uid))
    return EXIT_FAILURE;

? 

--
Charlie




More information about the busybox mailing list