[BusyBox] Re: login buggy also in 1.00pre5

[Tito]

On Tuesday 06 January 2004 16:16, Tito wrote:
> On Tuesday 06 January 2004 14:38, Tito wrote:
> > Hi to all,
> > just by taking a look at login.c and compiling it with -pedantic I
> > noticed a few things:
> >
> > 1) 2 c++ style comments at line 27 and 34 .
> > 2) and a suspicious line at 221
> > 	if ( check_nologin ( pw-> pw_uid == 0 ))
> > 		return EXIT_FAILURE;
> > Should it not be ?
> > 	if ( check_nologin ( pw-> pw_uid ) == 0 )
> > 		return EXIT_FAILURE;
>
> Sorry , but I didn't understand what it was doing.
> so it's not suspicious at all........... ;-P
>  Tito
maybe something like :
 	if ( check_nologin ( (pw-> pw_uid == 0) ) == 1)
 		return EXIT_FAILURE;
would be easier to understand for the non-gurus. ;-)
> > Ciao,
> > TITO
> >
> > _______________________________________________
> > busybox mailing list
> > busybox at mail.busybox.net
> > http://busybox.net/mailman/listinfo/busybox
>
> _______________________________________________
> busybox mailing list
> busybox at mail.busybox.net
> http://busybox.net/mailman/listinfo/busybox