[BusyBox] Re: login buggy also in 1.00pre5

Tito farmatito at tiscali.it
Tue Jan 6 14:38:55 UTC 2004


Hi to all,
just by taking a look at login.c and compiling it with -pedantic I noticed a
few things:

1) 2 c++ style comments at line 27 and 34 .
2) and a suspicious line at 221
	if ( check_nologin ( pw-> pw_uid == 0 ))
		return EXIT_FAILURE;
Should it not be ?
	if ( check_nologin ( pw-> pw_uid ) == 0 )
		return EXIT_FAILURE;

Ciao,
TITO




More information about the busybox mailing list