[BusyBox] busybox 1.00-pre8 & DHCP Patch

Russ Dill Russ.Dill at asu.edu
Fri Feb 27 02:41:39 UTC 2004


On Thu, 2004-02-26 at 01:15, Glenn McGrath wrote:
> On Thu, 26 Feb 2004 18:42:27 +1100
> Glenn McGrath <bug1 at iinet.net.au> wrote:
> 
> > Russ, there are a couple of outstanding patches to udhcp.
> > 
> > [BusyBox] [PATCH] add udhcpd --foreground option
> > http://www.busybox.net/lists/busybox/2004-February/010625.html

If at all possible, I'd like to see a smaller version of this patch.
Also, in the end, you'd probably want to remove the #ifndef UDHCP_DEBUG.

> > 
> > [BusyBox] PATCH - DHCP Addtional Items - ReDux
> > http://www.busybox.net/lists/busybox/2004-February/010740.html

This patch is good, and a long time in coming, however, I'd like to see
standardized formatting, ie, if (require_option(optarg)) {, instead of
if( require_option(optarg) ){. Also, I'm not sure if you want udhcpc to
bomb if an option isn't found, just print a log message and continue,
since different versions might support different options, and not having
an option is not necessarily fatal. And, don't forget to update the help
in busybox, as well as the man page.

> And this recent one also.
> 
> [BusyBox] [PATCH] udhcp build options
> http://www.busybox.net/lists/busybox/2004-February/010901.html

Also good, but again, don't forget to update the udhcp along with the
busybox help.
> 
> ______________________________________________________________________

-- 
Russ Dill <Russ.Dill at asu.edu>




More information about the busybox mailing list